[WireSVN] 2200 Multiple Files in lua: Cleanup, fixes and changes.

[Divran]

*coughholoScaleUnitscough*

If that was fixed it would fuck up a lot of contraptions, but your more than welcome to fix it.

Errrr holoScaleUnits doesn't use the E2 toUnit functions...

e2function void holoScaleUnits(index, vector size)
	local Holo = CheckIndex(self, index)
	if not Holo then return end
	
	local propsize = Holo.ent:OBBMaxs() - Holo.ent:OBBMins()
	local x = size[1] / propsize.x
	local y = size[2] / propsize.y
	local z = size[3] / propsize.z
	
	rescale(Holo, Vector(x, y, z))
end

[Colonel Thirty Two]

If that was fixed it would fuck up a lot of contraptions, but your more than welcome to fix it.

and if it does its not hard to fix.

It won't do anything serious; it may make a hologram *slightly* larger until the workaround code in the person's E2 is removed.

@Divran What about the resize function? I know for a fact that holoScaleUnits resizes slightly smaller than the real dimensions.

[Grocel]

@Divran What about the resize function? I know for a fact that holoScaleUnits resizes slightly smaller than the real dimensions.

Holo functions doesn't use the unit convert functions of the e2, they only takes the unchanged source units. The converting from the unit that you always get and need in source to cm, meter, inch, feet and so on was changed. Maybe you should test it you self to prove that it works.

[Divran]

It won't do anything serious; it may make a hologram *slightly* larger until the workaround code in the person's E2 is removed.

No, it won't. This code doesn't affect the need for *1.04 in holoScaleUnits.

@Divran What about the resize function? I know for a fact that holoScaleUnits resizes slightly smaller than the real dimensions.

above

[Colonel Thirty Two]

I'm not talking about E2 toUnits or this patch. Though I am still not sure why holoScaleUnits is slightly smaller than the given unit.

[Divran]

Ok should we commit it? I vote yes.

[Grocel]

Ok should we commit it? I vote yes.

Nice to hear your yes vote.

Anymore votes?

[Tolyzor]

I vote yes. We could always make an official poll.

[Drunkie]

It's a good patch. I don't see the need for a vote, just commit it.

[Divran]

Committed.