[zASM]Wire keybiad help

[ryland]

Hi guys I have gotten bored with making E2 OS's and decided to make one in zASM, now I am trying to get this code to work but I get a Write/Read error, ive sat looking at the code for an hour now and cant figure it out.
Here is how I have it wired up:
Memory1 -> Console Screen
Memory2 -> Keyboard

And here is the code.

DATA;
define key_off,67586;     //Second byte of Keyboard Mem
define con_off,65536;     //First byte of Console Mem
alloc charpos,0;          //Counter used to determine postion of keys in Writer.

CODE;
Write:             //General Write Function
 mov ebx,#key_off;  //Move Key to ebx save to write back to buffer
 mov eax,con_off;   //Set eax to start of console memory
 add eax,#charpos;  //Add to eax the value of the counter (charpos)
 mov #eax,#key_off; //Move character into console
 inc eax;           //Move to next cell over
 mov #eax,999;      //Move charparam into cell
 mov #key_off,ebx;  //Write char back to keyboard buffer
 add #charpos,2;    //Move to next cell, ready to write
jmp Write;         //Go back to key detection

And yes it is not my code but I would like to see some working code before I write my own.

Cookies and +reps are open.

[Bull]

It's filling your screens memory with 0's since it doesn't actually check if there is something in the buffer.

I'm rusty on cpu, but I believe this should work.

DATA;
define key_buffer,67585;
define key_off,67586;     //Second byte of Keyboard Mem
define con_off,65536;     //First byte of Console Mem
alloc charpos,0;          //Counter used to determine postion of keys in Writer.

CODE;

CheckLoop:
  mov ebx,key_buffer;
  cmp #ebx,0;
  cg Write;
jmp CheckLoop;

Write:             //General Write Function
 mov ebx,#key_off;  //Move Key to ebx save to write back to buffer
 mov eax,con_off;   //Set eax to start of console memory
 add eax,#charpos;  //Add to eax the value of the counter (charpos)
 mov #eax,#key_off; //Move character into console
 inc eax;           //Move to next cell over
 mov #eax,999;      //Move charparam into cell
 mov #key_off,ebx;  //Write char back to keyboard buffer
 add #charpos,2;    //Move to next cell, ready to write
ret;         //Go back to key detection

[ryland]

It's filling your screens memory with 0's since it doesn't actually check if there is something in the buffer.

I'm rusty on cpu, but I believe this should work.

DATA;
define key_buffer,67585;
define key_off,67586;     //Second byte of Keyboard Mem
define con_off,65536;     //First byte of Console Mem
alloc charpos,0;          //Counter used to determine postion of keys in Writer.

CODE;

CheckLoop:
  mov ebx,key_buffer;
  cmp #ebx,0;
  cg Write;
jmp CheckLoop;

Write:             //General Write Function
 mov ebx,#key_off;  //Move Key to ebx save to write back to buffer
 mov eax,con_off;   //Set eax to start of console memory
 add eax,#charpos;  //Add to eax the value of the counter (charpos)
 mov #eax,#key_off; //Move character into console
 inc eax;           //Move to next cell over
 mov #eax,999;      //Move charparam into cell
 mov #key_off,ebx;  //Write char back to keyboard buffer
 add #charpos,2;    //Move to next cell, ready to write
ret;         //Go back to key detection

Thanks, but I still get the same error, 7.676 or something close to that.
Also what does cg mean, ive never seen that before.

[Matte]

cg - Call if greater than

[ryland]

cg - Call if greater than

Ahh cool, that will come in handy soon.

EDIT:
Well, I did not have the address bus configured at all, big oops.
But I got it partly working...
The screen keeps repeating what you type until this...

[ChimP]

I've seen BP talk about this. Keyboards aren't working right now. You need to make a keybuffer on your own somehow.

[ryland]

I've seen BP talk about this. Keyboards aren't working right now. You need to make a keybuffer on your own somehow.

What do you mean by that?
Also, this is how I have the address bus configured.
Memory1 offset = 0
Memory1 size = 2047
Memory2 offset = 2048
Memory2 size = 255

EDIT:
And here is a picture of it before it goes dead.

[ChimP]

What do you mean by that?

The keybuffer is broken. It doesn't clear the last character, for some reason.
You should make your own one in E2.

[Bull]

What do you mean by that?
Also, this is how I have the address bus configured.
Memory1 offset = 0
Memory1 size = 2047
Memory2 offset = 2048
Memory2 size = 255

EDIT:
And here is a picture of it before it goes dead.

Memory1 size should be 2048
Memory2 size should be 256

[Fizyk]

You would want keyboard_buffer to be 67584 and keyboard_off to be 67585. Then it should work better, now you are checking wrong cells. And sizes don't really matter here, but making them 2048 and 256 would be better. Just make sure Mem2 offset is 2048.