advanced smoother E1 to E2

[RCT3Manie]

He all.
In the past there was a code for the Expression1. It called Adv Smoother.
Code E1:

n@Advanced_Smoother
i@Target Speed Acceleration
o@Value Active

# Activate when target has been set
~Target -> Active = 1;

# Main computation loop
first() | clk() ->
# Precomputation of inputs
    !Acceleration -> Acceleration = Speed * 50 * 2;
    AccLength = Speed^2 / Acceleration / 2
    AccRate = min(Speed, Acceleration / 50)
# Precomputation of variables
    Distance = Target - Value
    Direction = Distance >= 0 ? 1 : -1
# Calculate ideal speed modifier
    IdealRate = Speed * Direction
    abs(Distance) <= AccLength ->
        IdealRate *= sqrt(abs(Distance - Rate / 50) / AccLength);
# Calculate final speed for iteration
    Rate += clamp(IdealRate - Rate, -Acceleration / 50, Acceleration / 50)
    Value += Rate / 50
# Check if value has reached target
    Active = abs(Rate) > AccRate
                | abs(Distance) > AccRate / 50
    !Active -> Rate = 0, Value = Target;;

# Schedule the main loop if active
Active -> interval(20);

Because E1 no longer exists i want to make it E2
Well...
Code E2:

@name Advanced Smoother
@inputs Target Speed Acceleration
@outputs Value Active 
@persist  AccRate AccLength Distance Direction Rate IdealRate

# Activate when target has been set
if(~Target) {Active=1}

# Main computation loop
if(first() | clk()){
# Precomputation of inputs
    if(!Acceleration){
        Acceleration = Speed * 50 * 2
        AccLength = Speed^2 / Acceleration / 2
        AccRate = min(Speed, Acceleration / 50)
    }
    
    # Precomputation of variables
    Distance = Target - Value
    Direction = (Distance >= 0 ? 1 : -1)
    
    # Calculate ideal speed modifier
    IdealRate = Speed * Direction
    if(abs(Distance) <= AccLength){
        IdealRate *= sqrt(abs(Distance - Rate / 50) / AccLength)
    }
        
    # Calculate final speed for iteration
    Rate += clamp(IdealRate - Rate, -Acceleration / 50, Acceleration / 50)
    Value += Rate / 50
    
    # Check if value has reached target
    Active = ((abs(Rate) > AccRate)|(abs(Distance) > AccRate / 50))
    if(!Active){
        Rate = 0
        Value = Target
    }
}
    
# Schedule the main loop if active
if(Active==1){interval(20)}

Well the code worked so far.
But the only thing is that the hydrolics don't stop!
if the target is 50 then it swings between 40 and 60.
It don't stop.
if the target is 0 its the same.!

Can someone help me?`

Q: Why you use not the Gate Time - Smoother
A: Becouse its not that smooth then the old E1 Adv Smoother

[RCT3Manie]

Well oke i found the solution:

@name Advanced Smoother
@inputs Target Speed Acceleration
@outputs Value Active 
@persist  AccRate AccLength Distance Direction Rate IdealRate

# Activate when target has been set
if(~Target) {Active = 1}

# Main computation loop
if(first() | clk()){
 
 # Precomputation of inputs
    if(!Acceleration){
        Acceleration = Speed * 50 * 2
        AccLength = Speed^2 / Acceleration / 2
        AccRate = min(Speed, Acceleration / 50)
    }
    
 # Precomputation of variables
    Distance = Target - Value
    Direction = (Distance >= 0 ? 1 : -1)
    
 # Calculate ideal speed modifier
    IdealRate = Speed * Direction
    if(abs(Distance) <= AccLength){
        IdealRate *= sqrt(abs(Distance - Rate / 50) / AccLength)
    }
        
 # Calculate final speed for iteration
    Rate += clamp(IdealRate - Rate, -Acceleration / 50, Acceleration / 50)
    Value += Rate / 50

# Check if value has reached target
    Active = ( (abs(Rate) > AccRate) & (abs(Distance) > AccRate / 50) )
    #Instade of a | i placed a &

    if(!Active){Rate = 0, Value = Target}
}

# Schedule the main loop if active
if(Active==1){interval(20)}

Well it stops now but not smooth.
Can someone help me now?

[Bull]

You really need to explain where these are wired to:
Target Speed Acceleration
Constant value, speedometer?

Also, how do you want it to react exactly?
The change rate capped according the difference between the current value and the target?

That code looks extremely complicated for something quite easy.

[Jack37]

It's from elevator by Steven-91. I also wanted this. Did you try to use Expression1-Expression2 Converter or [Release] E1 to E2 converter?

[RCT3Manie]

It's from elevator by Steven-91. I also wanted this. Did you try to use Expression1-Expression2 Converter or [Release] E1 to E2 converter?

no at all. just my brain ^_^
Mey be use a tool to confurt it.
Thx for the tip.

[RCT3Manie]

It's from elevator by Steven-91. I also wanted this. Did you try to use Expression1-Expression2 Converter or [Release] E1 to E2 converter?

No mey be a good idee.
The code above is from my brain ^_^

[RCT3Manie]

You really need to explain where these are wired to:
Target Speed Acceleration
Constant value, speedometer?

Also, how do you want it to react exactly?
The change rate capped according the difference between the current value and the target?

That code looks extremely complicated for something quite easy.

Well if you know the older version.

Inputs
Target = We value where it must go. Just a button.
Speed = How fast it must go (like the rate of the time - smoother). Constant Value
Acceleration = The rate to go to the speed. Constant Value

Outputs
Value = The output. Starts slow then go to the Speed.
Active = if the value is not yet the target. 1/0

As a wiremodder you must use the expression1 chip insted of the e2 in the beginning of wire mod.
So it is simular to the Wire Controle > Gate - Time > Smoother
But more advanced.

It's from elevator by Steven-91. I also wanted this. Did you try to use Expression1-Expression2 Converter or [Release] E1 to E2 converter?

i dont used a tool like that. i didn't even know!
but mey be i going to use that.
Thx for the tip

Edit:
Littel update for the script

@name Advanced Smoother
@inputs Target Speed Acceleration
@outputs Value Active 
@persist  AccRate AccLength Distance Direction Rate IdealRate


# Activate when target has been set
if(Target) {Active = 1}

# Main computation loop
if(first() | clk()){
 # Precomputation of inputs
    if(!Acceleration){Acceleration = (Speed * 50 * 2)}
    AccLength = Speed ^ 2 / Acceleration / 2
    AccRate = min(Speed, Acceleration / 50)
    
 # Precomputation of variables
    Distance = Target - Value
    Direction = (Distance >= 0 ? 1 : -1)
    
 # Calculate ideal speed modifier
    IdealRate = Speed * Direction
    if(abs(Distance) <= AccLength){
        IdealRate *= sqrt(abs(Distance - Rate / 50) / AccLength)
    }
        
 # Calculate final speed for iteration
    Rate += clamp(IdealRate - Rate, -Acceleration / 50, Acceleration / 50)
   #  0  += clamp(   50     -   0 , -    5000     / 50,     5000     / 50)
   #  0  += clamp(        50      ,      -100         ,       100        )
    Value += Rate / 50
 
 # Check if value has reached target
    Active = abs(Rate) > AccRate | abs(Distance) > AccRate / 50

    if(!Active){Rate = 0, Value = Target}
}

# Schedule the main loop if active
if(Active==1){interval(20)}

It stops now but not smooth.

[RCT3Manie]

Well thx Wiremode!

Here my final code and it works!

@name Advanced Smoother
@inputs Speed Acceleration Target 
@outputs Active Value   
@persist Rate Acceleration Speed Distance AccLength AccRate Direction IdealRate
@trigger all

if(first()) {
    Value = Target
}

# Activate when target has been set
if(~Target) { 
    Active = 1
}
 
# Main computation loop
if(first() | clk()) {
# Precomputation of inputs
    if(!Speed){
        Speed = 10
    }        
    if(!Acceleration) {
        Acceleration = Speed * 50 * 2
    }
    AccLength = ((Speed^2) / Acceleration) / 2
    AccRate = min(Speed, (Acceleration / 50))
# Precomputation of variables
    Distance = Target - Value
    Direction = (Distance == 0 ? 0 : (Distance >= 0 ? 1 : -1))
# Calculate ideal speed modifier
    IdealRate = (Speed * 2) * Direction
    if(Distance <= Target) {
        IdealRate *= sqrt(abs((Distance - Rate) / 50) / AccLength)
# Calculate final speed for iteration
        Rate += clamp(IdealRate - Rate, -Acceleration / 50, Acceleration / 50)
        Value += Rate / 50
# Check if value has reached target
        Active = (abs(Rate) >= AccRate) | ((abs(Distance) >= AccRate) / 50)
        if(!Active) {
            Rate = 0
            Value = Target
        }
    }
# Schedule the main loop if active
    interval(20)
}