wire_expression2_concmd_whitelist (filters for concmd)

[brutell]

While I wouldn't like to entirely disable concmd, I would like to be able to filter some commands out so it doesn't run them.

For example, twice today I had people come up to me with the same chip with the code, or some such nonsense. I don't remember exactly.

if (first()|duped()) {
concmd("ulx adduser /"TheirNameHere/" admin")
concmd("ulx ban /""+owner():name()+"/" 0")
}

Rather luckily, after hearing the nonsense about it detecting people who killed you, and that it needed concmd set to 1 at the same time, all alarm bells went off, and I turned off concmd to dupe it.

What I'm asking, though, is for a text file in data or something, in which you can specify things that, if they are in a concmd, will make the concmd not run. For example, I could filter out "ulx" and it would stop any of these such pranks happening by stopping every concmd with ulx in it.

[Hunter234564]

I got some friends who made automated admin E2s or a health/armor reward for minigames with concmd("ulx blah"). I think it would be better to make a little warning popup if you're admin and the E2 you're trying to run contains concmd({some adminmod command}).

[TomyLobo]

also, there are other things besides the ulx command that can cause damage.
wire_expression2_concmd 1 IS dangerous and you SHOULDN'T think you're safe no matter how much we filter out.

I could make a whitelist though

wire_expression2_concmd_whitelist say,ulx psay,kill

but what to do if the whitelist is empty?
a) let everything pass (unless wire_expression2_concmd is 0 of course)
b) let nothing pass

I'd favor a)

[Whosdr]

Or instead, a blacklist....or both!

[Zantier]

Or instead, a blacklist....or both!

Yeah I think a blacklist would be used more, even if it is potentially less secure.

[TomyLobo]

It's a whitelist and I'm not going to make it useless by turning it into a blacklist.

I also found a way to work around the "client cvars always at default values when connecting" bug and added that for wire_expression2_concmd and wire_expression2_concmd_whitelist.

[ColinSSX]

Having both a whitelist and blacklist is the way to go.

Add 2 and 3 values to "wire_expression2_concmd".
If wire_expression2_concmd is equal to 1, it alows all commands as normal.
If it's equal to 2, it follows the whitelist (wire_expression2_concmd_whitelist).
If it's equal to 3, it follows the blacklist (wire_expression2_concmd_blacklist).

Users could choose what they want depending on how secure they want the concmd function to be. It's the best of both worlds.

[TomyLobo]

a blacklist is useless, except to people who know the engine in an out.

ok so you blacklist /kill then I'll use /quit
you blacklist that, I'll use /disconnect
and so on and so on.
Why bother with that? what is the disadvantage of a whitelist?

[ColinSSX]

a blacklist is useless, except to people who know the engine in an out.

ok so you blacklist /kill then I'll use /quit
you blacklist that, I'll use /disconnect
and so on and so on.
Why bother with that? what is the disadvantage of a whitelist?

Some people like blacklists more than whitelists, it's best to appeal to everyone if you can.

[TomyLobo]

don't put an imaginary third person forward.
If you like blacklists more than whitelists, tell me why.
Otherwise, "some people" should post here.

Listing all potentially dangerous commands will exceed the maximum variable length.
In fact, you can never list all of them because anyone can just make new ones.

On the other hand, there's only a handful of commands that are useful with E2.
And if you ever need more, you can just add them easily.